feat(coalesce): add size function - #10331
Merged
Merged
Conversation
rluvaton
marked this pull request as ready for review
July 13, 2026 18:02
mzabaluev
reviewed
Jul 14, 2026
mzabaluev
left a comment
mzabaluev
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I only have some editorial changes for the comments.
Co-authored-by: Mikhail Zabaluev <mikhail.zabaluev@gmail.com>
9 tasks
Rich-T-kid
approved these changes
Jul 18, 2026
Rich-T-kid
left a comment
Rich-T-kid
left a comment
Contributor
There was a problem hiding this comment.
nice, I think this will be a nice addition to datafusion
Jefffrey
approved these changes
Jul 24, 2026
Contributor
|
thanks @rluvaton, @mzabaluev & @Rich-T-kid |
Jefffrey
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
But this is prerequisite for:
FilterExec,RepartitionExec,HashJoinExecandAsyncFuncExecand more due toLimitedBatchCoalescerand arrowBatchCoalescerusage datafusion#23385Rationale for this change
We want to be able to reserve memory for the data that
BatchCoalesceris using in DataFusion and other placesWhat changes are included in this PR?
added
sizefunctions and implement sizing + testsAre these changes tested?
Yes
Are there any user-facing changes?
yes, new function